Confirmation modal for new both DREF Operational Update and final report #2048

shreeyash07 · 2025-10-16T12:54:25Z

Addresses

Issue(s):

Depends On

https://github.com/IFRCGo/go-api

Changes

Confirmation modal for new Dref Operational update
Update Finalize confirmation message

This PR Ensures:

No typos or grammatical errors
No conflict markers left in the code
No unwanted comments, temporary files, or auto-generated files
No inclusion of secret keys or sensitive data
No console.log statements meant for debugging
All CI checks have passed

changeset-bot · 2025-10-16T12:54:29Z

⚠️ No Changeset found

Latest commit: 7fc2569

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

AdityaKhatri · 2025-10-27T08:36:34Z

translationMigrations/000052-1760421406280.json

@@ -1,11 +1,11 @@
 {
-    "parent": "000051-1758354992698.json",


Lets remove translation migration for now. We can do that all together in the future.

this might be the last PR for the Project branch,

frozenhelium · 2025-10-29T02:41:00Z

app/src/components/domain/GoMultiFileInput/index.tsx

        formData: true,
        url,
        method: 'POST',
+        useCurrentLanguageForMutation: true,


We should pass this down as prop and use it only where necessary, this might affect the other places where input is currently being used

frozenhelium · 2025-10-29T02:41:24Z

app/src/components/domain/GoSingleFileInput/index.tsx

        // FIXME: fix typing in server (low priority)
        // the server generated type for response and body is the same
        body: (body) => body as never,
+        useCurrentLanguageForMutation: true,


We should pass this down as prop and use it only where necessary, this might affect the other places where input is currently being used

frozenhelium · 2025-10-29T02:43:04Z

app/src/views/AccountMyFormsDref/DrefTableActions/styles.module.css

+.add-ops-update-modal {
+    display: flex;
+    flex-direction: column;
+    gap: var(--go-ui-spacing-lg);
+}


Is this styling needed?

Yes it is needed for now.

frozenhelium · 2025-10-29T02:45:26Z

app/src/utils/restRequest/go.ts

+    } else if (method === 'POST' || method === 'PUT' || method === 'PATCH') {
        // Mutation
-        defaultHeaders['Accept-Language'] = useCurrentLanguageForMutation ? currentLanguage : 'en';
+        if (isDefined(enforceLanguageForMutation)) {
+            defaultHeaders['Accept-Language'] = enforceLanguageForMutation;
+        } else if (useCurrentLanguageForMutation) {
+            defaultHeaders['Accept-Language'] = currentLanguage;
+        } else {
+            defaultHeaders['Accept-Language'] = 'en';
+        }


We might need to add default fallback as well

frozenhelium · 2025-11-05T03:16:28Z

translationMigrations/000053-1760619346791.json

Let's remove this file for now, the project branch already has 2 migration file which starts with 52

shreeyash07 requested review from AdityaKhatri, barshathakuri and frozenhelium October 16, 2025 12:54

shreeyash07 assigned frozenhelium Oct 16, 2025

shreeyash07 temporarily deployed to test October 16, 2025 12:54 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test October 16, 2025 12:55 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test October 16, 2025 12:56 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test October 17, 2025 10:02 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test October 17, 2025 10:03 — with GitHub Actions Inactive

shreeyash07 changed the title ~~Confirmation modal for new DREF Operational Update~~ Confirmation modal for new both DREF Operational Update and final report Oct 17, 2025

shreeyash07 temporarily deployed to test October 17, 2025 10:03 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test October 17, 2025 12:17 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test October 17, 2025 12:18 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test October 17, 2025 12:19 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test October 17, 2025 13:14 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test October 17, 2025 13:15 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test October 17, 2025 13:16 — with GitHub Actions Inactive

barshathakuri approved these changes Oct 27, 2025

View reviewed changes

AdityaKhatri approved these changes Oct 27, 2025

View reviewed changes

AdityaKhatri reviewed Oct 27, 2025

View reviewed changes

frozenhelium reviewed Oct 29, 2025

View reviewed changes

shreeyash07 temporarily deployed to test November 4, 2025 09:00 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test November 4, 2025 09:01 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test November 4, 2025 09:02 — with GitHub Actions Inactive

frozenhelium requested changes Nov 5, 2025

View reviewed changes

shreeyash07 temporarily deployed to test November 5, 2025 08:58 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test November 5, 2025 08:59 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test November 5, 2025 09:00 — with GitHub Actions Inactive

frozenhelium force-pushed the project/dref-translation branch from c427aa6 to 4623c15 Compare November 5, 2025 09:03

shreeyash07 force-pushed the feature/ops-update-changes branch from b55d9e6 to 6fee040 Compare November 5, 2025 09:27

shreeyash07 temporarily deployed to test November 5, 2025 09:27 — with GitHub Actions Inactive

shreeyash07 temporarily deployed to test November 5, 2025 09:28 — with GitHub Actions Inactive

shreeyash07 and others added 5 commits November 5, 2025 15:21

feat(dref-translation): update dref status and publish api to approve

954c806

feat(dref-translation): add ops update confirmation modal

030f19d

feat(dref-translation): add final report confirmation modal

19422c3

fix(dref-translation): add enforce selected langauge in useLazyRequest

6fee040

feat(active-dref-table): add finalizing status

7fc2569

frozenhelium temporarily deployed to test November 5, 2025 11:04 — with GitHub Actions Inactive

frozenhelium temporarily deployed to test November 5, 2025 11:05 — with GitHub Actions Inactive

frozenhelium deployed to test November 5, 2025 11:06 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Confirmation modal for new both DREF Operational Update and final report #2048

Confirmation modal for new both DREF Operational Update and final report #2048

Uh oh!

shreeyash07 commented Oct 16, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

AdityaKhatri Oct 27, 2025

Uh oh!

shreeyash07 Oct 28, 2025

Uh oh!

frozenhelium Oct 29, 2025

Uh oh!

frozenhelium Oct 29, 2025

Uh oh!

frozenhelium Oct 29, 2025

Uh oh!

shreeyash07 Nov 4, 2025

Uh oh!

frozenhelium Oct 29, 2025

Uh oh!

frozenhelium Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Confirmation modal for new both DREF Operational Update and final report #2048

Are you sure you want to change the base?

Confirmation modal for new both DREF Operational Update and final report #2048

Uh oh!

Conversation

shreeyash07 commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Addresses

Depends On

Changes

This PR Ensures:

Uh oh!

changeset-bot bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shreeyash07 commented Oct 16, 2025 •

edited

Loading

changeset-bot bot commented Oct 16, 2025 •

edited

Loading